Implement equals and hashCode in ImmutablePublicKeyCredentialUserEntity#18883
Open
aspan wants to merge 1 commit intospring-projects:mainfrom
Open
Implement equals and hashCode in ImmutablePublicKeyCredentialUserEntity#18883aspan wants to merge 1 commit intospring-projects:mainfrom
aspan wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
changed the title
jzheaux
added
type: enhancement
jzheaux
requested changes
Mar 21, 2026
| if (!(obj instanceof ImmutablePublicKeyCredentialUserEntity that)) { | ||
| return false; | ||
| } | ||
| return Objects.equals(getName(), that.getName()) && Objects.equals(getId(), that.getId()); |
Contributor
There was a problem hiding this comment.
Will you please use this.name/that.name and this.id/that.id? The reason is so that this class doesn't get surprised with overridden implementations, should this class ever become non-final.
...va/org/springframework/security/web/webauthn/api/ImmutablePublicKeyCredentialUserEntity.java
Show resolved
Hide resolved
jzheaux
added
the
status: waiting-for-feedback
Signed-off-by: Andreas Asplund <andreas@asplund.biz>
Contributor
Author
|
Hi Thanks for the feedback. I've made the requested changes. |
spring-projects-issues
added
status: feedback-provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.